Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add light and dark mode in Playground #1175

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

cpcramer
Copy link
Contributor

@cpcramer cpcramer commented Aug 27, 2024

What changed? Why?

Add light and dark mode in Playground

  • Add darkMode: ['class'] and safelist: ['dark'] in our tailwind.config.ts files. This prevents the users personal mac settings from overriding our components styling.
Screenshot 2024-08-27 at 5 06 51 PM Screenshot 2024-08-27 at 5 06 58 PM

Notes to reviewers

How has it been tested?

@github-actions github-actions bot added the root label Aug 27, 2024
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 0:07am
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 0:07am
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 0:07am

@cpcramer cpcramer changed the title Add playground light and dark modes chore: Add light and dark mode in Playground Aug 28, 2024
@@ -36,7 +58,7 @@ function Demo() {
View Github
</a>
</div>
<div className="flex flex-1 flex-col bg-[linear-gradient(to_right,#f0f0f0_1px,transparent_1px),linear-gradient(to_bottom,#f0f0f0_1px,transparent_1px)] bg-[size:6rem_4rem]">
<div className="linear-gradient(to_bottom,#f0f0f0_1px,transparent_1px)] flex flex-1 flex-col bg-[linear-gradient(to_right,#f0f0f0_1px,transparent_1px), bg-[size:6rem_4rem]">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to cut this into multiple lines but the linter is preventing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use cn of clx for this

@Zizzamia Zizzamia merged commit 1c73305 into main Aug 28, 2024
16 checks passed
@Zizzamia Zizzamia deleted the paul/light-mode-dark-mode-playground branch August 28, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants